From fea99e99d5b71b0c0a071bfbc611e3108ad53977 Mon Sep 17 00:00:00 2001 From: Sander Speetjens Date: Mon, 19 Aug 2024 01:57:52 +0200 Subject: [PATCH] b UI_checkbox fix bad implementation of toggle_selected --- src/UI/UI_checkbox.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/UI/UI_checkbox.cpp b/src/UI/UI_checkbox.cpp index bd3d6b1..7cbf80b 100644 --- a/src/UI/UI_checkbox.cpp +++ b/src/UI/UI_checkbox.cpp @@ -24,14 +24,10 @@ void UI_checkbox::toggle_selected(size_t selected) { if (selected >= p_options.size()) return; - - if (p_selected[selected] != p_selected[selected]) + p_selected[selected] = !p_selected[selected]; + if (p_on_change != nullptr) { - p_selected[selected] = !p_selected[selected]; - if (p_on_change != nullptr) - { - p_on_change(p_id, selected_text()); - } + p_on_change(p_id, selected_text()); } }