From fbf8f5309068d02a5ff8ba6e0aa8c8362a492c74 Mon Sep 17 00:00:00 2001 From: Sander Speetjens Date: Mon, 20 Oct 2025 20:48:52 +0200 Subject: [PATCH] server Ensures that the message parser returns a default "{}" response after handling an event, preventing unintended empty responses. Also, this change avoids sending empty messages to the client unnecessarily. --- server/message_parser.cpp | 6 +----- server/simulators.cpp | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/server/message_parser.cpp b/server/message_parser.cpp index 6777af3..3c43293 100644 --- a/server/message_parser.cpp +++ b/server/message_parser.cpp @@ -13,12 +13,8 @@ QString Simulators::message_parser(QString message) else if (j.contains("event")) { event_handler(j["event"]); - return ""; - } - else - { - return ""; } + return "{}"; } json Simulators::command_parser(json command) diff --git a/server/simulators.cpp b/server/simulators.cpp index 28d2d97..aa6373d 100644 --- a/server/simulators.cpp +++ b/server/simulators.cpp @@ -62,7 +62,7 @@ Simulators::Simulators(uint16_t port, QString can_dev, QString uart_dev, QObject connect(m_server, &Websocket::on_message, this, [this](QWebSocket *conn, QString message) { QString response = message_parser(message); - if (response.isEmpty() || response == "{}") + if (response == "{}") return; m_server->send(conn, response); });