sani7/2023-Webservices_And_Applications
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

modbus_tcp

Browse Source 
checking if ext is null but not utilising it to skip over the strcmp's
This commit is contained in:
Sander Speetjens
2023-11-28 13:10:34 +01:00
parent 103098d2a7
commit 984f1dbe26
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
project/Core/Src/modbus_tcp.c
View File

@@ -109,8 +109,7 @@ static err_t modbus_incoming_data(void* arg, struct tcp_pcb* pcb, struct pbuf* p
const char* ext = strrchr(file_list[registers[REG_IMAGE_NR] - 1].name, '.'); const char* ext = strrchr(file_list[registers[REG_IMAGE_NR] - 1].name, '.');
if (ext == NULL) { if (ext == NULL) {
LOG_CRIT(TAG, "No valid extension found"); LOG_CRIT(TAG, "No valid extension found");
} } else if (strcmp(ext, ".gif") == 0) {
if (strcmp(ext, ".gif") == 0) {
lcd_draw_gif_from_fs(file_list[registers[REG_IMAGE_NR] - 1].name, 0, 75); lcd_draw_gif_from_fs(file_list[registers[REG_IMAGE_NR] - 1].name, 0, 75);
} else if (strcmp(ext, ".bmp") == 0) { } else if (strcmp(ext, ".bmp") == 0) {
lcd_draw_img_from_fs(file_list[registers[REG_IMAGE_NR] - 1].name, 0, 75); lcd_draw_img_from_fs(file_list[registers[REG_IMAGE_NR] - 1].name, 0, 75);