sani7/2023-Webservices_And_Applications
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tftp

Browse Source 
- Remove the suggestion of null terimination of the custom_fread custom_fwrite functions
- Update the tests
This commit is contained in:
Sander Speetjens
2023-12-06 14:58:41 +01:00
parent fc997e1aac
commit 0023659552
2 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/tfpt_tests.cpp
View File

@@ -77,20 +77,27 @@ TEST(TFTP, custom_fwrite) {
}
TEST(TFTP, custom_fread_fwrite_suggested_by_Lorenz) {
char buf[21];
write_file.data = (char*)malloc(21 * sizeof(char));
write_file.len = 21;
write_file.offset = 0;
tftp_custom_fwrite("1234567890123456789", 19, &write_file);
tftp_custom_fwrite("0987654321", 10, &write_file);
EXPECT_EQ(write_file.offset, 20);
tftp_custom_fwrite("0987654321", 11, &write_file);
// the above function does not write the null terminator
EXPECT_EQ(write_file.offset, 21);
EXPECT_EQ(write_file.len, 21);
EXPECT_EQ(memcmp(write_file.data, "12345678901234567890", 21), 0);
EXPECT_EQ(memcmp(write_file.data, "12345678901234567890", 20), 0);
tftp_custom_fseek(&write_file, 0, SEEK_SET);
tftp_custom_fread(buf, 20, &write_file);
// the above function does not write the null terminator
buf[20] = '\0';
EXPECT_EQ(memcmp(buf, "12345678901234567890", 21), 0);
free(write_file.data);
write_file.data = NULL;
write_file.len = 0;
char buf[21];
file.offset = 9;
tftp_custom_fread(buf, 20, &file);
EXPECT_EQ(memcmp(buf, "0", 2), 0);